Skip to content

fix(expo): theme native iOS custom profile pages - #10272

Open
juliusmarminge wants to merge 1 commit into
clerk:mainfrom
juliusmarminge:fix/expo-profile-page-theme-only
Open

juliusmarminge wants to merge 1 commit into
clerk:mainfrom
juliusmarminge:fix/expo-profile-page-theme-only

Conversation

@juliusmarminge

Copy link
Copy Markdown

Description

Custom user-profile pages on iOS do not apply the Clerk theme to their content backgrounds and navigation bars. Apply the theme colors and the existing solid-navigation-bar modifier so these pages match the rest of the profile UI.

To verify, open a custom profile page with a custom dark theme and inspect the content background and navigation bar, including on iOS versions before Liquid Glass.

The package's 43 JavaScript tests and package build pass with this change; Swift syntax parsing passes. Fresh simulator evidence remains pending, so this PR is a draft.

Prepared with GPT-6.1 through Codex on behalf of @juliusmarminge.

Checklist

  • pnpm test runs as expected for @clerk/expo-native-components.
  • pnpm build runs as expected for @clerk/expo-native-components.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-bot Bot commented Oct 16, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 5acb0a6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@clerk/expo-native-components Patch
@clerk/expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Oct 16, 2026

Copy link
Copy Markdown

@juliusmarminge is attempting to deploy a commit to the Clerk Production Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository YAML (base), Organization UI (inherited)
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: f07df4bb-0ce0-4129-93e7-32e0000893b6
📥 Commits

Reviewing files that changed from the base of the PR and between abec9c4 and 5acb0a6.

📒 Files selected for processing: 2
  • .changeset/quiet-profile-custom-page-theme.md
  • packages/expo-native-components/ios/ClerkNativeBridge.swift
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

📝 Walkthrough

The iOS custom user-profile page now reads the Clerk theme, uses its muted color behind the page, configures a solid navigation bar, and applies the theme background. The navigation title and inline title display remain unchanged. A patch changeset records the update for @clerk/expo-native-components.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Merge Risk: ⚪ Minimal · up to 5acb0

The custom page applies the configured theme colors, and the existing navigation modifier covers pre-Liquid-Glass iOS. No actionable merge-blocking risk is established.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: applying themes to native iOS custom profile pages in Expo.
Description check Passed The description directly explains the missing theme behavior, the iOS changes, verification steps, and test results.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@wobsoriano
wobsoriano marked this pull request as ready for review October 16, 2026 04:44

@wobsoriano wobsoriano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Tested on an iOS 27 simulator with a custom dark theme.

Right part here has a custom page that picks up the theme background and matches the pages around it 👍🏼

side-by-side-main-left-pr-right.mp4

@pkg-pr-new

pkg-pr-new Bot commented Oct 16, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@10272

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@10272

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@10272

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@10272

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@10272

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@10272

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@10272

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@10272

@clerk/expo-biometrics

npm i https://pkg.pr.new/@clerk/expo-biometrics@10272

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@10272

@clerk/expo-native-components

npm i https://pkg.pr.new/@clerk/expo-native-components@10272

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@10272

@clerk/express

npm i https://pkg.pr.new/@clerk/express@10272

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@10272

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@10272

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@10272

@clerk/mosaic

npm i https://pkg.pr.new/@clerk/mosaic@10272

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@10272

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@10272

@clerk/react

npm i https://pkg.pr.new/@clerk/react@10272

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@10272

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@10272

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@10272

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@10272

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@10272

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@10272

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@10272

commit: 5acb0a6

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants