Repository navigation
fix(expo): theme native iOS custom profile pages - #10272
juliusmarminge wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 5acb0a6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@juliusmarminge is attempting to deploy a commit to the Clerk Production Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
wobsoriano
left a comment
There was a problem hiding this comment.
Looks good! Tested on an iOS 27 simulator with a custom dark theme.
Right part here has a custom page that picks up the theme background and matches the pages around it 👍🏼
side-by-side-main-left-pr-right.mp4
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-biometrics
@clerk/expo-google-signin
@clerk/expo-native-components
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/mosaic
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
Description
Custom user-profile pages on iOS do not apply the Clerk theme to their content backgrounds and navigation bars. Apply the theme colors and the existing solid-navigation-bar modifier so these pages match the rest of the profile UI.
To verify, open a custom profile page with a custom dark theme and inspect the content background and navigation bar, including on iOS versions before Liquid Glass.
The package's 43 JavaScript tests and package build pass with this change; Swift syntax parsing passes. Fresh simulator evidence remains pending, so this PR is a draft.
Prepared with GPT-6.1 through Codex on behalf of @juliusmarminge.
Checklist
pnpm testruns as expected for@clerk/expo-native-components.pnpm buildruns as expected for@clerk/expo-native-components.Type of change