-
Notifications
You must be signed in to change notification settings - Fork 3
fix(env): surface CLERK_PLATFORM_API_URL credential mismatch
#344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rafa-thayto
wants to merge
3
commits into
main
Choose a base branch
from
fix/platform-api-url-credential-warning
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
627fd6b
fix(env): surface CLERK_PLATFORM_API_URL credential mismatch
rafa-thayto e59876a
fix(env): normalize URLs before comparing to avoid spurious mismatch …
rafa-thayto 39bbf59
refactor(env): extract isPlatformApiUrlOverridden and move warn to ca…
rafa-thayto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "clerk": patch | ||
| --- | ||
|
|
||
| Warn (in human mode) when `CLERK_PLATFORM_API_URL` routes requests to a host that differs from the active environment's URL, since credentials are keyed by environment name and not by URL. `clerk doctor` now also reports the active environment and its API URL so the mismatch is visible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| import { test, expect, describe, beforeEach, afterEach } from "bun:test"; | ||
| import { isPlatformApiUrlOverridden } from "./environment.ts"; | ||
|
|
||
| describe("isPlatformApiUrlOverridden", () => { | ||
| const original = process.env.CLERK_PLATFORM_API_URL; | ||
|
|
||
| beforeEach(() => { | ||
| delete process.env.CLERK_PLATFORM_API_URL; | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| if (original === undefined) delete process.env.CLERK_PLATFORM_API_URL; | ||
| else process.env.CLERK_PLATFORM_API_URL = original; | ||
| }); | ||
|
|
||
| test("returns overridden=true with URLs when the override differs from the active env URL", () => { | ||
| process.env.CLERK_PLATFORM_API_URL = "https://api.staging.example.com"; | ||
| const result = isPlatformApiUrlOverridden(); | ||
| expect(result.overridden).toBe(true); | ||
| if (!result.overridden) return; | ||
| expect(result.overrideUrl).toBe("https://api.staging.example.com"); | ||
| expect(result.profileUrl).toBe("https://api.clerk.com"); | ||
| expect(result.envName).toBe("production"); | ||
| }); | ||
|
|
||
| test("returns overridden=false when no override is set", () => { | ||
| const result = isPlatformApiUrlOverridden(); | ||
| expect(result.overridden).toBe(false); | ||
| }); | ||
|
|
||
| test("returns overridden=false when the override equals the active env URL", () => { | ||
| process.env.CLERK_PLATFORM_API_URL = "https://api.clerk.com"; | ||
| const result = isPlatformApiUrlOverridden(); | ||
| expect(result.overridden).toBe(false); | ||
| }); | ||
|
|
||
| test("returns overridden=false when URLs differ only by trailing slash", () => { | ||
| process.env.CLERK_PLATFORM_API_URL = "https://api.clerk.com/"; | ||
| const result = isPlatformApiUrlOverridden(); | ||
| expect(result.overridden).toBe(false); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.