feat(init): remove --prompt and bundled agent prompt templates#241
feat(init): remove --prompt and bundled agent prompt templates#241rafa-thayto wants to merge 3 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 5b13001 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
e44d1fe to
88c3754
Compare
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (28)
📝 WalkthroughWalkthroughThe pull request removes the interactive Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 56 minutes and 3 seconds.Comment |
The `clerk init --prompt` short-circuit and the per-framework prompt templates under `commands/init/prompts/` are removed. Agents should run `clerk init -y` for non-interactive setup, or install the published skills directly via `skills add clerk/skills`. Move the `pmInstallCommand` helper to `lib/package-manager.ts` (its only non-prompt consumer was `init/heuristics.ts`) and lift the `*.md` text import declaration to `globals.d.ts` so `skills.ts` and `skill/install.ts` keep compiling.
- Remove unnecessary `declare module "*.md"` from globals.d.ts — the
prompt .md files that needed it were deleted, and remaining .md imports
use `with { type: "text" }` import attributes instead.
- Consolidate install-command logic: `globalInstallCommand` in
installer.ts now reuses `pmInstallCommand` from package-manager.ts for
bun/pnpm/npm, keeping the PM-to-command mapping in a single place.
The ambient module declaration for `*.md` files was incorrectly removed
in the previous commit. It's still needed because `skill/install.ts`
imports `.md` files — while the `with { type: "text" }` attribute tells
Bun how to load them at runtime, TypeScript still requires the ambient
declaration for type resolution.
5b13001 to
cc648ad
Compare
Summary
clerk init --promptflag and the per-framework prompt templates that lived inpackages/cli-core/src/commands/init/prompts/. Agents should now runclerk init -yfor the full non-interactive flow, or install the published skills directly viaskills add clerk/skills.pmInstallCommandhelper tolib/package-manager.ts(it lived next to the prompt templates only because they referenced it; its only other consumer wasinit/heuristics.ts).declare module "*.md"text-import declaration from the deletedprompts/md.d.tsintoglobals.d.tssoskills.tsandskill/install.tskeep type-checking.init --promptas a non-side-effecting smoke test for--input-jsonand--appregistration are rewritten to assert viaclerk.raw(nounknown optionin stderr / structured agent error format) without depending on the removed flag.README.md, thecli-program.tsexamples, and thescaffold.tsdoc comment are updated to drop--promptreferences.Versioning
Released as a
minorbump rather thanmajor—--prompthad no known users, so the removal is treated as additive cleanup rather than a breaking change.Test plan
bun run format:checkbun run lintbun run typecheckbun run test(93 passed)bun run test:e2e:op