Upgrade workspace and fixtures to TypeScript 6

[rafa-thayto]

Summary

• upgrade the workspace and checked-in fixtures to typescript@6.0.2
• add explicit Bun ambient types and root/cli-core typecheck entrypoints for TS6
• fix cli-core TS6 diagnostics and align tests and fixtures with the new compiler behavior

Commits

• build: upgrade workspace to TypeScript 6.0.2
• fix: resolve TypeScript 6 diagnostics in cli-core
• test: align cli-core tests with TypeScript 6
• chore: upgrade e2e fixtures to TypeScript 6

Verification

• bun install
• bun run typecheck
• bun run build
• bun run test
• cd packages/cli-core/mocks && bun install && bunx tsc --noEmit
• Bun-based smoke validation for touched fixtures:
  • nextjs-app-router
  • nextjs-pages-router
  • nextjs-app-router-next14
  • react-router
  • react
  • vue
  • tanstack-start

Notes

• bun run test:e2e was not run because this environment does not have the required Clerk e2e secrets (CLERK_PLATFORM_API_KEY, CLERK_CLI_TEST_APP_ID, etc.)

[wyattjoh]

Code Review — PR #137

Reviewed with Opus + Codex second-opinion validation.

Blocker

B1. bun run format:check fails on packages/cli-core/src/lib/help.ts:105-115 (codex confirmed)
The terms.map arrow body was converted from an expression to a block but the indent/wrapping parens around helper.formatItem(...) were not re-formatted. CI format:check will reject. Run bun run format and re-push.

Major

M1. Branch is very stale (codex partial)
Merge-base is 85f7cb3b (Nov 2025); main is at 1d746017. ~15 PRs merged since, including changeset enforcement, Homebrew distribution, NonEmptyArray helpers, PKCE rejection sampling, skill infrastructure, and removal of log.ts / runners.ts / installer.ts. Reviewing this PR without rebasing cannot predict post-rebase behavior; the TS 6 sweep will almost certainly conflict with help.ts / spinner.ts / constants.ts. Rebase onto current main, re-run bun run format:check / lint / typecheck / test, then re-open for review.

M2. Next 14 fixture opts out of noUncheckedSideEffectImports rather than fixing the side-effect import (codex confirmed)
test/e2e/fixtures/nextjs-app-router-next14/tsconfig.json:7 sets "noUncheckedSideEffectImports": false. TS 6 has this on by default, and the fixture is meant to represent what downstream users of clerk init would get. Either fix the offending side-effect import in the fixture (preferred; matches user reality), or update the init scaffolder to inject the opt-out into generated Next 14 tsconfigs.

Minor

• m1. Vite-based framework test fixtures (react.test.ts:19, react-router.test.ts:18, tanstack-start.test.ts:18, vue.test.ts:18) set framework.envFile = ".env", but canonical FrameworkInfo in lib/framework.ts:45-77 declares .env.local for these frameworks. Tests pass because nothing asserts on this field today.
• m2. Root typecheck script (package.json:10) covers only @clerk/cli-core; scripts/**/*.ts and e2e fixtures are not validated under TS 6.
• m3. No changeset. Touches runtime cli-core files (auth-server.ts, constants.ts, dotenv.ts, help.ts, spinner.ts, heuristics.ts, transformations.ts, react-router.ts). Post-rebase, the Enforce Changeset workflow will require one; add a patch-level changeset for @clerk/cli-core.
• m4. ProjectContext.envFile: string is wider than FrameworkInfo.envFile: ".env" | ".env.local" (frameworks/types.ts:11). Tightening to the literal union would turn m1 into a compile error.

Nits

• FRAMES[0]! fallback in spinner.ts:99 is defensive cruft for a non-empty tuple; typing FRAMES as const removes the need.
• env-paths {suffix: ""} in constants.ts:15 is behaviorally equivalent to the old {suffix: false} (both falsy); no migration concern, noted for the reviewer's benefit.

Positives

Switching from expect(arr[0].foo).toBe(...) to destructure + toBeDefined() + optional chaining is the right pattern for noUncheckedIndexedAccess. FrameworkTemplateName = Exclude<TemplateName, "generic"> is a correct fix: the prior Exclude<TemplateName, "generic" | "generic-fallback"> was wrong because "generic-fallback" is actually referenced as a framework template in FRAMEWORK_PROMPTS.vite.template. TS 6 forced the discovery of a latent type bug. plapi.test.ts was rewritten to use getPlapiBaseUrl() rather than hardcoding api.clerk.com, making the suite portable across environments. heuristics.ts added an explicit "Invalid package manager install command" guard rather than silently propagating undefined.

[rafa-thayto]

Code Review -- PR #137

I reviewed the full diff against main. wyattjoh's earlier review is thorough and accurate; I'll confirm the blocker/majors and add one finding that wasn't called out.

Blocker

B1. help.ts formatting -- confirmed. The terms.map rewrite (lines 105-112) has misaligned closing parens. bun run format will fix it, but CI format:check will reject as-is.

B2. Stale branch -- confirmed. The merge-base is months behind main. A rebase is needed before this can land cleanly. Several touched files (help.ts, spinner.ts, constants.ts, prompts) have diverged.

New finding

init/index.test.ts -- fwOverride.envFile uses ".env" for Next.js, but FRAMEWORK_MAP defines Next.js as ".env"... that's correct. However, the existingCtx object on the same file (around line 243 in the diff) sets publishableKeyEnv to "x" in the old code -- the PR replaces this with proper envVar/envFile fields, but sets envFile: ".env" on the ProjectContext level while the framework also gets envFile: ".env". This is fine for Next.js. But FAKE_CTX (the React fixture) has framework.envFile: ".env" when the canonical FRAMEWORK_MAP entry for React is .env.local. This is pre-existing on main, but since this PR adds an explicit ProjectContext type annotation to FAKE_CTX, TS6 will happily accept it (both are valid literals in the union). Worth fixing while you're here to keep test fixtures honest -- change it to ".env.local" to match production. Confidence: 82/100.

Confirming wyattjoh's review

All the points from the prior review hold up:

• M2 (noUncheckedSideEffectImports opt-out): Agreed. The Next 14 fixture disabling it is a workaround, not a fix. Worth investigating the offending import.
• m3 (missing changeset): Confirmed. The Enforce Changeset workflow requires one since runtime files under packages/cli-core/src/ are touched. An empty changeset (bun changeset --empty) is the right call here since this is an internal toolchain upgrade.
• Positives: The FrameworkTemplateName fix, getPlapiBaseUrl() in tests, setFetchMock helper, and safe index access patterns are all solid improvements.

No additional blockers found. The PR is well-structured and the TS6 fixes are correct. Just needs the rebase, format pass, changeset, and the minor fixture fixes before it's ready to merge.

[changeset-bot]

🦋 Changeset detected

Latest commit: 0f88d29

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR