Skip to content

Add waitless to UI Testing - #142

Open
godhiraj-code wants to merge 1 commit into
cleder:mainfrom
godhiraj-code:add-waitless
Open

godhiraj-code wants to merge 1 commit into
cleder:mainfrom
godhiraj-code:add-waitless

Conversation

@godhiraj-code

@godhiraj-code godhiraj-code commented Oct 19, 2026 •

Copy link
Copy Markdown

Adds waitless (MIT, on PyPI as waitless) to UI Testing. I'm the author.

It wraps a Selenium WebDriver so get, find_element and click wait until the DOM and network have settled (strict mode also waits for animations and layout), which removes most time.sleep() calls and explicit WebDriverWait boilerplate in Python Selenium tests.

The entry goes at the end of the section to keep alphabetical order.

Summary by Sourcery

New Features:

  • Add waitless to the curated Python testing resources for Selenium-based UI testing.

@semanticdiff-com

Copy link
Copy Markdown

Review changes with  SemanticDiff

@sourcery-ai

sourcery-ai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR adds waitless to the UI Testing section of the README, describing its Selenium WebDriver wrapper and automatic DOM, network, animation, and layout synchronization capabilities.

File-Level Changes

Change Details Files
Adds waitless to the UI testing resource list as a Selenium synchronization wrapper.
  • Documents automatic waiting for navigation, element lookup, and clicks until DOM and network activity settle.
  • Notes strict-mode support for waiting on animations and layout, reducing explicit waits and sleeps.
  • Places the entry alphabetically within the UI Testing section.
README.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@qodo-code-review

qodo-code-review Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Code Review by Qodo

Grey Divider

Sorry, something went wrong

We weren't able to complete the code review on our side. Please try again manually by commenting /agentic_review on this PR.

Grey Divider

Qodo Logo

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Add waitless to the UI Testing resources

📝 Documentation 🕐 Less than 5 minutes

Grey Divider

AI Description

• List waitless among Python UI testing resources.
• Describe its automatic Selenium waits for navigation, element lookups, and clicks.
High-Level Assessment

A README entry is the appropriate approach for adding a resource to this curated list; no architectural alternative is needed.

Files changed (1) +1 / -0

Documentation (1) +1 / -0
README.mdList waitless under UI Testing +1/-0

List waitless under UI Testing

• Adds a link to waitless after squape in the UI Testing section. The entry describes its automatic waits for Selenium navigation, element lookups, and clicks, including stricter animation and layout checks.

README.md

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@mergify

mergify Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@llamapreview llamapreview Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LlamaPReview — No blocking issues found

Single documentation line adds a well-formed waitless entry in the correct alphabetical slot of the UI Testing list, matching the section's format; no code, config, or runtime surface changes.

1 non-blocking finding retained — highest: Entry inclusion rests on a maintainer editorial call, not a verifiable defect.

Review details and evidence
Priority File Finding Evidence
P2 README.md Entry inclusion rests on a maintainer editorial call, not a verifiable defect needs verification

Finding details

P2 · Entry inclusion rests on a maintainer editorial call, not a verifiable defect

README.md

The submitter is the project author and the link target is the submitter's own GitHub repository, so inclusion rests on an editorial decision about a young project rather than any fact the diff can prove or disprove. Comparable Selenium-wrapper entries (helium, selene, LuluTest, pomcorn) make the entry's kind consistent with the section; any unstated maturity bar is outside the changed mechanism. This note does not carry a merge decision.

Owner action: Optional: apply any unstated curation/maturity policy for self-submitted projects; no code change needed.

Verification boundary: needs verification; scope: changed region.

Material unknowns

  • Whether the list requires MIT licensing and a PyPI distribution for entries, as the PR description asserts for waitless. No effect on the merge posture — the entry links to the GitHub project, consistent with most entries here, and no supplied evidence states a licensing or PyPI-linkage requirement.
    • Check: Optional: confirm against any unstated list policy for licensure or package-index linkage.

LlamaPReview checks

  • Read the complete PR-head file README.md.
  • Reviewed changed regions in README.md.

Still coding alone? Open CarbonChat, a chat room right inside Codex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant