update to node 24 packages #1366
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
commented
Nov 17, 2025
| await mongoStore.collection.drop() | ||
| await mongoStore.close() | ||
| if (mongoStore) { | ||
| await mongoStore.collection.drop() |
Author
There was a problem hiding this comment.
I found during some local testing that the before() function didn't always complete before after() which would mean the variable mongoStore was still undefined and this line would throw.
JamieMagee
reviewed
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all, I'm Brett and I'm a software engineer at Microsoft. We use ClearlyDefined a lot internally and I was asked by my management to update some things in this repo. I figured I should start with something small and hopefully easy to review. Some of the node-adjacent packages used referenced either node 20 or outdated Docker images so this is an attempt to rectify that.
My plan for future PRs is to update various dependencies as required along with improving test coverage where possible.
I'm open to any and all feedback and if you'd like the feedback to be private, you can email me directly at
brettfo@microsoft.com.