Repository navigation
A video above 1080p uploads as its original - #93
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The media service's playable copies stop at 1080p. A video whose short side is above 1080 now uploads in parts to the service's own storage, which keeps the file as sent, and the service makes its playable copy from there. Exports do not read the original yet; that comes next.
/api/assets/originals; the finished video joins the library like any upload.Known gap: if the answer to the final join is lost after the service has joined the parts, a retry is refused and that video is not in the library.
315 unit tests, typecheck, build and the e2e suite pass (new block 17). Not yet run against the real storage.