Repository navigation
Captions that fit on two lines, corrected words, and a transcript to download - #91
Merged
Merged
Conversation
…download Caption size is now a share of the frame's shorter side. As a share of the height, the same setting was nearly twice as large on a vertical video, each line held half the words, and captions wrapped to three lines. A caption is also kept to what fits on two lines, and there is an extra small size. What a cue says can be corrected in the Captions panel; the fix is kept in the clip's transcript, so every video cut from it shows it. A video's transcript downloads as text with times, from the Captions panel and from a library video's hover controls. On a short screen the rail's last tabs (Captions, Review) were below the fold with no way to reach them: the tabs are icons only there, and the column scrolls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From a client call: captions on vertical clips were large and wrapped to three lines, there was no way to fix a caption's words or to get a video's transcript out, and on a small laptop screen the Captions tab could not be reached.
What changes
wrapLinesno longer spends a third line when words do not split evenly (it affects text overlays too, only where they wrapped to more lines than the width needs).PUT /api/assets/{id}/transcript/cues), so every video cut from that clip shows it.GET /api/assets/{id}/transcript/text, one[m:ss] wordsline per cue. Linked from the Captions panel and from a library video's hover controls.Known limit
Asking for a transcript in another language replaces the kept one, corrections included (there is one transcript per clip). Stated in
agent.md.Checked
pnpm typecheck,pnpm test(314),pnpm test:e2epass; new unit tests for sizing, the two-line rule over every size, line length and shape, and the VTT round trip; e2e for both routes.