Detect direct Locale#t calls based on type information#1343
Open
filipsobol wants to merge 6 commits intomasterfrom
Open
Detect direct Locale#t calls based on type information#1343filipsobol wants to merge 6 commits intomasterfrom
Locale#t calls based on type information#1343filipsobol wants to merge 6 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
packages/ckeditor5-dev-translations/tests/utils/gettypescriptmessages.js
Outdated
Show resolved
Hide resolved
Member
|
Confirm manually please, if this solution does not re-introduce this problem – https://github.com/ckeditor/ckeditor5-internal/issues/3115. |
Member
Author
As mentioned in the original comment, I already ran I checked this case again, and it's still covered. I added regression tests, just so we don't reintroduce this in the future. |
Locale#t calls during translation validation and synchronization.Locale#t calls based on type information
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

🚀 Summary
Detect direct
Locale#tcalls (such aseditor.locale.t(),editor.t(),locale.t(), andthis.t()) during translation validation and synchronization based on type information.📌 Related issues
💡 Additional information
I ran
translations:validateandtranslations:synchronizein both repositories, and it worked correctly.The old mechanism still works for JS-only files. However, TS sources will now be based on more accurate type information.