Conversation
Add config option to disable github version checks civo#313 Added a new flag DisableVersionCheck to the metadata struct. Modified CivoAPIClient to check DisableVersionCheck before making API calls. Updated loadConfig to ensure the version check only happens if DisableVersionCheck is false. Updated saveUpdatedConfig to properly serialize the modified config.
fulviodenza
reviewed
May 6, 2025
Contributor
fulviodenza
left a comment
fulviodenza
left a comment
There was a problem hiding this comment.
Thanks for your contribution, please remove first the comments. I'll give it a look ASAP
Contributor
Author
|
@fulviodenza @giornetta Comments cleared, please review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add config option to disable github version checks #313
Added a new flag DisableVersionCheck to the metadata struct.
Modified CivoAPIClient to check DisableVersionCheck before making API calls.
Updated loadConfig to ensure the version check only happens if DisableVersionCheck is false.
Updated saveUpdatedConfig to properly serialize the modified config.