Allow more flexibility in extracting a template key#4
Open
tsufiev wants to merge 1 commit intocivicsource:masterfrom
Open
Allow more flexibility in extracting a template key#4tsufiev wants to merge 1 commit intocivicsource:masterfrom
tsufiev wants to merge 1 commit intocivicsource:masterfrom
Conversation
* introduce a new option 'templateName' which can contain all interpolations to be used in `interpolateName` (see https://www.npmjs.com/package/loader-utils#interpolatename ) * pass all options directly to `interpolateName`, so that 'regExp' option could be used as well (see examples in above link).
chadly
suggested changes
Apr 26, 2018
Author
|
Hi! It turned out that for my purposes being just able to have a precise control over template name/id is not enough. Since there is a lot of templates in my project, and most of them are small reusable snippets not required directly from js code, I have 2 options when using webpack to deal with them:
I'd prefer to use the 2nd approach - so I'm going to push a couple more commits, once I figure out how to implement the recursive template sourcing :/. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
interpolations to be used in
interpolateName(seehttps://www.npmjs.com/package/loader-utils#interpolatename )
interpolateName, so that 'regExp'option could be used as well (see examples in above link).