Add libFuzzer targets#89
Open
k-wasniowski wants to merge 2 commits into
Open
Conversation
bifurcation
requested changes
May 13, 2026
Contributor
bifurcation
left a comment
bifurcation
left a comment
There was a problem hiding this comment.
Couple minor things, overall LGTM
| auto ciphertext = input_bytes(data + 1, size - 1); | ||
|
|
||
| CipherSuite suite; | ||
| switch (suite_selector) { |
Contributor
There was a problem hiding this comment.
Seems like it would be simpler just to cast the suite_selector to CipherSuite? Or suite_selector + 1.
| auto plaintext_buf = std::vector<uint8_t>(size); | ||
| auto pt_out = output_bytes(plaintext_buf); | ||
|
|
||
| (void)ctx.unprotect(pt_out, ciphertext, {}); |
Contributor
There was a problem hiding this comment.
I dislike this void cast idiom. It looks like the more modern idiomatic way would be:
Suggested change
| (void)ctx.unprotect(pt_out, ciphertext, {}); | |
| std::ignore = ctx.unprotect(pt_out, ciphertext, {}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.