remove \r from file contents when read via USB repl #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@makermelissa hiya take a look at this one please when yr next working |
makermelissa
approved these changes
Jan 23, 2025
Collaborator
makermelissa
left a comment
makermelissa
left a comment
There was a problem hiding this comment.
Thanks. I can't remember why I added this before, but if it fixes the issue, then good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ladyada
Resolves: #285
When read via usb repl the file contains both
\r\nand the code editor renders both as empty lines. This change strips the\rleaving only a\nto be rendered.Tested successfully on a locally running instance.
