Skip to content

fix: pass prompt via stdin to avoid "Argument list too long" error #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jiwon01 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: pass prompt via stdin to avoid "Argument list too long" error #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions app/codex.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,8 +534,12 @@ def _build_cmd_and_env(
overrides: Optional[Dict] = None,
images: Optional[List[str]] = None,
model: Optional[str] = None,
) -> list[str]:
"""Build base `codex exec` command with configs and optional images."""
) -> tuple[list[str], str]:
"""Build base `codex exec` command with configs and optional images.

Returns (cmd, prompt_text). The prompt is passed via stdin (using
``-`` as positional arg) to avoid OS "Argument list too long" errors.
"""
cfg = {
"sandbox_mode": settings.sandbox_mode,
"hide_agent_reasoning": settings.hide_reasoning,
Expand Down Expand Up @@ -573,7 +577,7 @@ def _build_cmd_and_env(
_ensure_workdir_exists()

# Note: Rust CLI does not support `-q`. Use human output or JSON mode selectively.
cmd = [exe, "exec", prompt, "--color", "never"]
cmd = [exe, "exec", "-", "--color", "never"]
if _WORKDIR_NEEDS_SKIP_GIT_CHECK:
cmd.append("--skip-git-repo-check")
if images:
Expand Down Expand Up @@ -618,7 +622,7 @@ def _build_cmd_and_env(
toml_bool = "true" if allow_network else "false"
cmd += ["--config", f"sandbox_workspace_write={{ network_access = {toml_bool} }}"]

return cmd
return cmd, prompt


@lru_cache(maxsize=1)
Expand Down Expand Up @@ -943,14 +947,15 @@ async def run_codex(
model: Optional[str] = None,
) -> AsyncIterator[str]:
"""Run codex CLI as async generator yielding stdout lines suitable for SSE."""
cmd = _build_cmd_and_env(prompt, overrides, images, model)
cmd, prompt_text = _build_cmd_and_env(prompt, overrides, images, model)
codex_env = _build_codex_env()
output_filter = _CodexOutputFilter()

async with _parallel_limiter.slot():
try:
proc = await asyncio.create_subprocess_exec(
*cmd,
stdin=asyncio.subprocess.PIPE,
stdout=asyncio.subprocess.PIPE,
stderr=asyncio.subprocess.PIPE,
cwd=settings.codex_workdir,
Expand All @@ -968,6 +973,12 @@ async def run_codex(
except Exception as e:
raise CodexError(f"Unable to start codex process: {e}")

# Feed the prompt via stdin to avoid OS arg-length limits.
proc.stdin.write(prompt_text.encode())
await proc.stdin.drain()
proc.stdin.close()
await proc.stdin.wait_closed()

raw_lines: List[str] = []
try:
while True:
Expand Down Expand Up @@ -1005,7 +1016,7 @@ async def run_codex_last_message(

This avoids human oriented headers and logs from the CLI.
"""
cmd = _build_cmd_and_env(prompt, overrides, images, model)
cmd, prompt_text = _build_cmd_and_env(prompt, overrides, images, model)
# Create temp file in workdir to ensure permissions
_ensure_workdir_exists()
codex_env = _build_codex_env()
Expand All @@ -1016,14 +1027,15 @@ async def run_codex_last_message(
async with _parallel_limiter.slot():
proc = await asyncio.create_subprocess_exec(
*cmd,
stdin=asyncio.subprocess.PIPE,
stdout=asyncio.subprocess.PIPE,
stderr=asyncio.subprocess.PIPE,
cwd=settings.codex_workdir,
env=codex_env,
limit=_ASYNCIO_STREAM_LIMIT,
)
stdout_data, stderr_data = await asyncio.wait_for(
proc.communicate(), timeout=settings.timeout_seconds
proc.communicate(input=prompt_text.encode()), timeout=settings.timeout_seconds
)
if proc.returncode != 0:
stdout_text = (stdout_data or b"").decode(errors="ignore")
Expand Down