Skip to content

fix(quake): parse semver build metadata in image tags #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huklaa wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(quake): parse semver build metadata in image tags #278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 25 additions & 5 deletions crates/quake/src/cli_version.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,10 @@ pub(crate) fn ensure_cl_image_supported(image_tag: Option<&str>) -> Result<()> {
/// Extract a `(major, minor, patch)` tuple from an image tag.
///
/// Returns `Some` only for explicit parseable versions such as `v0.6.0`,
/// `arc_consensus:v0.5.1-rc1`, or `0.7.0`. Returns `None` for missing tags,
/// the `"latest"` tag, or tags that do not fit the `MAJOR.MINOR.PATCH[-...]`
/// pattern. [`apply_version_compat`] treats every `None` uniformly as
/// "assume the target supports every flag".
/// `arc_consensus:v0.5.1-rc1`, `v0.6.0+build.1`, or `0.7.0`. Returns `None`
/// for missing tags, the `"latest"` tag, or tags that do not fit the
/// `MAJOR.MINOR.PATCH[-...][+...]` pattern. [`apply_version_compat`] treats
/// every `None` uniformly as "assume the target supports every flag".
fn parse_image_semver(image_tag: Option<&str>) -> Option<(u64, u64, u64)> {
let tag = image_tag?;
let version_str = tag.rsplit(':').next().unwrap_or(tag);
Expand All @@ -66,12 +66,18 @@ fn parse_image_semver(image_tag: Option<&str>) -> Option<(u64, u64, u64)> {
}
let version_str = version_str.strip_prefix('v').unwrap_or(version_str);
let parts: Vec<&str> = version_str.split('.').collect();
// Prerelease and build metadata may contain dot-separated identifiers
// (e.g. -rc.1 or +build.1), so extra segments after MAJOR.MINOR.PATCH
// are valid.
if parts.len() < 3 {
return None;
}
let major = parts[0].parse::<u64>().ok()?;
let minor = parts[1].parse::<u64>().ok()?;
let patch_str = parts[2].split('-').next().unwrap_or(parts[2]);
let patch_str = parts[2]
.split(['-', '+'])
.next()
.unwrap_or(parts[2]);
let patch = patch_str.parse::<u64>().ok()?;
Some((major, minor, patch))
}
Expand Down Expand Up @@ -189,6 +195,9 @@ mod tests {
Some("arc_consensus:v0.6.0"),
Some("arc_consensus:v1.0.0"),
Some("v0.5.0-rc1"),
Some("v0.5.0-rc.1"),
Some("v0.5.0+build.1"),
Some("v0.5.0-rc1+build.1"),
Some("arc_consensus:abc123"),
] {
assert!(
Expand All @@ -207,6 +216,9 @@ mod tests {
"v0.4.0",
"0.4.0",
"v0.4.0-rc1",
"v0.4.0-rc.1",
"v0.4.0+build.1",
"v0.4.0-rc1+build.1",
] {
let err = ensure_cl_image_supported(Some(tag))
.expect_err(&format!("tag {tag} should be rejected"));
Expand Down Expand Up @@ -262,6 +274,10 @@ mod tests {
"v0.6.0",
"0.6.0",
"v0.6.0-rc1",
"v0.6.0-rc.1",
"v0.6.0+build.1",
"v0.6.0+2026-08-26",
"v0.6.0-rc1+build.1",
] {
let result = compat_flags(Some(tag));
assert!(
Expand All @@ -283,6 +299,10 @@ mod tests {
"v0.6.1",
"0.6.1",
"v0.6.1-rc1",
"v0.6.1-rc.1",
"v0.6.1+build.1",
"v0.6.1+2026-08-26",
"v0.6.1-rc1+build.1",
"v0.7.0-beta",
] {
let result = compat_flags(Some(tag));
Expand Down