feat(helper): implement IsRising utility#376
Open
SAY-5 wants to merge 1 commit into
Open
Conversation
Adds IsRising[T Number](c <-chan T, period int) <-chan T to the helper package. Returns 1 when the current value strictly exceeds the value n periods ago, 0 otherwise. 100% test coverage. Closes cinar#369 Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements the
IsRisinghelper function as specified in #369.Returns
1if the current value is strictly greater than the valuenperiods ago, and0otherwise.Implementation
helperpackage.func IsRising[T Number](c <-chan T, period int) <-chan TDuplicate,Buffered,Skip, andOperatefrom the existing helper primitives.Tests
Five test cases covering: mixed input, default period (1), all-rising, all-falling, and equal values. Coverage: 100% on
is_rising.go.Closes #369