fix: re-sort collection summaries after inferring usage - #22
Merged
dylandreimerink merged 2 commits intoAug 21, 2026
Merged
Conversation
Signed-off-by: immanuwell <pchpr.00@list.ru>
Signed-off-by: immanuwell <pchpr.00@list.ru>
dylandreimerink
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collection summaries are sorted before instruction-derived usage is applied. With optimized DWARF that leaves inferred entries in the old order, so the final list can be wrong. Low-key confusing.
The fix runs final values through the existing sorter. A Clang 22 fixture covers it too.
Repro before this fix:
entryshould come first by name.The CI linter is updated to 2.13 for Go 1.27 support.
Tests:
go test ./...,go test -race ./...,go vet ./...,golangci-lint run,make -C testdata docker