Skip to content

fix: include void functions in collection summaries - #21

Merged
dylandreimerink merged 1 commit into
cilium:mainfrom
immanuwell:fix-void-function-summaries
Aug 19, 2026
Merged

fix: include void functions in collection summaries#21
dylandreimerink merged 1 commit into
cilium:mainfrom
immanuwell:fix-void-function-summaries

Conversation

@immanuwell

@immanuwell immanuwell commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Collection summaries skip concrete void BPF-to-BPF functions because they have no DW_AT_type.
This is a real gotcha since void helpers are normal BPF code, and direct lookup already works

The fix checks for code addresses or ranges instead. Declaration-only entries stay filtered

Repro:

$ go run ./cmd/stackwhere list testdata/noinline.o
  8 bytes - entry

Before, helper is missing. After the fix:

  8 bytes - entry
  0 bytes - helper

Tests: go test -v ./..., go test -race ./..., go vet ./..., golangci-lint run ./...

Signed-off-by: immanuwell <pchpr.00@list.ru>

@dylandreimerink dylandreimerink left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks again!

@dylandreimerink
dylandreimerink merged commit 2570999 into cilium:main Aug 19, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants