Cleanup refactor#1902
Open
jrajahalme wants to merge 2 commits into
Open
Conversation
Member
jrajahalme
commented
May 12, 2026
jrajahalme
commented
- Refactor for future changes
- rename npds_config as config_source
jrajahalme
added
the
clean-up
Refactor policy code in preparation for delta NPDS changes in later commits: - Remove unnecessary PortPolicy.map_ member. - Move NetworkPolicyMapImpl to cilium/network_policy.cc to hide implementation detail. - Add helpers for policy updates to be shared with the delta code later. - Pass Context to secret watcher functions instead of the full NetworkPolicyMap. - Simplify gRPC subscribe() parameters. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
The new config source in BpfMetadata config is also used the Secrets referenced in the policy, as well as NPHDS, so it's more honest to call it just "config_source". Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
jrajahalme
force-pushed
the
cleanup-refactor
branch
from
d09feb5 to
9d94273
Compare
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.