Skip to content

Feat: separate loaded list per Revit version#74

Open
chuongmep wants to merge 2 commits into
devfrom
fix-separate-loaded-list-per-revit-version-5325653799585024780
Open

Feat: separate loaded list per Revit version#74
chuongmep wants to merge 2 commits into
devfrom
fix-separate-loaded-list-per-revit-version-5325653799585024780

Conversation

@chuongmep

Copy link
Copy Markdown
Owner

Added a setting "Separate loaded list per Revit version" to avoid conflicts when multiple Revit instances are running on the same machine. Now correctly utilizes ExternalCommandData.Application.Application.VersionNumber when configured.


PR created automatically by Jules for task 5325653799585024780 started by @chuongmep

Co-authored-by: chuongmep <31106432+chuongmep@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@chuongmep

Copy link
Copy Markdown
Owner Author

No, please don't use System.Resources.Extensions, I need maintenance support version with .NET framework <= 4.8.1 as well

@google-labs-jules

Copy link
Copy Markdown

No, please don't use System.Resources.Extensions, I need maintenance support version with .NET framework <= 4.8.1 as well

I have removed the changes to System.Resources.Extensions in RevitAddinManager.csproj to maintain support for .NET framework <= 4.8.1. Instead of using VersionChecker.CurrentVersion which returns the AddInManager version, I am now correctly capturing the Revit Host version through the ExternalCommandData.Application.Application.VersionNumber and injecting it into the AddinManager constructor so that GetIniFilePaths() constructs the separate path based on the Revit version when the setting is enabled.

Co-authored-by: chuongmep <31106432+chuongmep@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant