chore(package.json): update to httpxy@0.5.3#1234
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThis PR improves IPv6 target normalization by converting unspecified addresses (::) to loopback (::1) and preserving credentials in bracketed targets. It also migrates certificate generation from selfsigned to mockttp in E2E tests and updates the httpxy dependency. ChangesIPv6 Normalization and Test Infrastructure
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| let authorizationHeader: string | undefined; | ||
|
|
||
| await targetServer.forGet('/api').thenCallback((req) => { | ||
| await targetServer.forGet('/api/').thenCallback((req) => { |
There was a problem hiding this comment.
https://github.com/unjs/httpxy/releases/tag/v0.5.3 is out
unjs/httpxy#142 will add ci to make sure it won't happen again
There was a problem hiding this comment.
Updated this branch to v0.5.3.
Can confirm the revert is working. 🙌
The local patch for mockttp is also working. Just have to wait for httptoolkit/mockttp#201 to land.
Thanks for the fast response and providing an awesome solution with the ecosystem test 🙏
commit: |
commit: |
Update to httpxy@0.5.3
Dependent on:
bump to mockttp@4.4.2
removed
selfsigneddependency:selfsignedconflicted withmockttpbecause both pull in the@peculiar/x509and@peculiar/asn1-*stack, but not at the same versions.That mattered because those libraries use schema registration at runtime. Once
selfsignedintroduced a newer@peculiar/* tree,mockttpcould end up parsing keys/certs with classes from one version and schema storage from another. The result was the failure:Cannot get schema for 'RSAPublicKey' targetSummary by CodeRabbit
New Features
definePluginhelper function.Bug Fixes
Chores