fix(notes): keep player and timestamp links working after title changes - #321
Merged
Conversation
Opening an episode note now also checks the pre-2.17 filename sanitizer and a unique same-folder title match, so notes created before dots were preserved (or after a feed rearranges a title) stay linked. Timestamp links use the same title-overlap fallback against the live feed. Fixes #315
Deploying podnotes with
|
| Latest commit: |
118112a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://623d442d.podnotes.pages.dev |
| Branch Preview URL: | https://fix-315-legacy-note-title-lo.podnotes.pages.dev |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
CodeQL flagged the first-only /\n/ replace as incomplete sanitization. Filenames cannot contain leftover newlines, so making this global does not change note lookup.
The playing-episode URI shortcut now requires a full token-set match so a Part 1 timestamp cannot seek a loaded Part 2. Conflicting numeric tokens score 0, so a same-folder Part 2 note is not treated as Part 1. The tie-guard test now uses two candidates at the same qualifying score.
chhoumann
marked this pull request as ready for review
August 12, 2026 19:35
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e3f2d732cf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Same-folder note lookup now compares sanitized episode titles, not the
full basename, so a long {{podcast}} prefix cannot pull in a sibling.
Feed and local-file fallbacks require a full token-set match, and
findUniqueTitleMatch refuses whenever more than one candidate qualifies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Player-to-note and timestamp-to-player links broke after the 2.16 to 2.17 filename sanitizer change, and again when a feed rearranged an episode title. Existing notes were left at the old path or old
episodeName, so the player created a duplicate note and old timestamp links showed "Episode not found".Opening an episode note now tries the current path, then the 2.16 sanitizer path, then a unique same-folder title match. Timestamp links do the same title-overlap fallback against the live feed. New notes still write to the current sanitized path.
Verified in the isolated Obsidian e2e vault (1.13.4) against the live Philosophize This and Huberman Lab feeds from the issue.
Fixes #315