feat: migrate form to tanstack & zod #3810
Conversation
Deploying nmrium with
|
| Latest commit: |
3d7c489
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3113f4a1.nmrium.pages.dev |
| Branch Preview URL: | https://3809-start-using-tanstack-fo.nmrium.pages.dev |
|
The form now look like that with react-science components : 
|
|
Validation should not accept an empty string. |
Layout is not ok, please make sure it looks as nice as before. |
Do you want it to looks like this ? |
Not strictly. But the previous layout had a fixed width which made much more sense. Regarding button color, I don't know on what ground you changed the button color. Ok if it is for consistency reasons, but otherwise keep the original green color. |
|
@Sebastien-Ahkrin It seems you forgot this PR. |
…tack-form-and-zod-validation-with-react-science-components
Is this looking better ? @stropitek |
|
If we want the label text to not be centered, we have to change the react-science components |
|
Why is it centered? |
NVM its because i use DialogContent, i can change the behavior. its now done |
|
DialogContent is centered by default? |
yep it looks like that |
|
I see that DialogContent is a component defined in this file and only used here. I don't understand why you override the value instead of changing the component directly. Now I think we should entirely remove this component and just render DialogBody. |
stropitek
left a comment
stropitek
left a comment
There was a problem hiding this comment.
Previously, the input element was auto-focused. Now with the refactor it is not anymore.
Probably related to react-science, but I don't think the help message should be red. Only the error message.
Yep, to set the error / text message in other color, i have to change react-science. Same for auto-focus, i should change the behavior in react-science. |
…tack-form-and-zod-validation-with-react-science-components
|
@Sebastien-Ahkrin Can you fix the conflict and look into the E2E test failures? |
sure, i'm already working on it |
…tack-form-and-zod-validation-with-react-science-components
|
best i can to, with removing custom styles is : 
Questions, should we keep background of the dialog "white" or should it be gray (by default) ? |
|
when errored : |
targos
left a comment
targos
left a comment
There was a problem hiding this comment.
I think the default style is good.
Do you know how it works to close when we click on cancel since there is no onClick handler?
it doesn't, now it should be good ! |
|
Sebastien-Ahkrin
deleted the
3809-start-using-tanstack-form-and-zod-validation-with-react-science-components
branch
No description provided.