No Frozen String Warnings. UGH #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John McCrae <john.mccrae@progress.com>
tpowell-progress
requested changes
Dec 23, 2025
Contributor
tpowell-progress
left a comment
tpowell-progress
left a comment
There was a problem hiding this comment.
add a comment about the + operator
Co-authored-by: Thomas Powell <104777878+tpowell-progress@users.noreply.github.com>
Signed-off-by: John McCrae <john.mccrae@progress.com>
tpowell-progress
approved these changes
Dec 23, 2025
Signed-off-by: John McCrae <john.mccrae@progress.com>
|
rishichawda
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This gem causes a ludicrous amount of noise in the build pipeline logs because of the Frozen String warnings. Taking care of that here. Also tweaked a test that was failing because it was possible to load a profile/logo that would slow the test down enough that it would fail.
Related Issue
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.