feat(setups): add missing fields to PaymentSetupsRequest#620
Merged
armando-rodriguez-cko merged 1 commit intoJul 20, 2026
Merged
Conversation
The PaymentSetup schema includes billing_descriptor, presentment_details and terminal as writable fields. They are present in PaymentSetupsResponse but were missing from PaymentSetupsRequest. Add them so a Payment Setup can be created with a billing descriptor, presentment details, and terminal details.
|
david-ruiz-cko
approved these changes
Jul 20, 2026
armando-rodriguez-cko
deleted the
feat/payment-setups-request-missing-fields
branch
July 20, 2026 16:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add the
billingDescriptor,presentmentDetailsandterminalfields toPaymentSetupsRequest.Why
The
PaymentSetupschema defines these as writable fields, and they are already present inPaymentSetupsResponse, but they were missing from the request. This left the request unable to set a billing descriptor, presentment details, or terminal details when creating a Payment Setup.Surfaced by a full request/response audit of the payment setups endpoint against the swagger spec (follow-up to the confirm-response alignment in 7.12.0/7.12.1).
Verification
./gradlew compileJava— passes.setups.entities(used by the response).