fix: send MDNs to self even if MDNs are disabled - #8578
Merged
Conversation
link2xt
force-pushed
the
link2xt/always-send-mdn-to-self
branch
2 times, most recently
from
August 13, 2026 09:57
6fd8ad6 to
3a3f972
Compare
link2xt
marked this pull request as ready for review
August 13, 2026 10:01
link2xt
commented
Aug 13, 2026
| /// Tries to send a single MDN. Returns true if more MDNs should be sent. | ||
| async fn send_mdn(context: &Context, smtp: &mut Smtp) -> Result<bool> { | ||
| if !context.should_send_mdns().await? { | ||
| context.sql.execute("DELETE FROM smtp_mdns", []).await?; |
Collaborator
Author
There was a problem hiding this comment.
Started by removing only non-self MDNs, but then removed the whole block. If the user disabled MDNs, it seems fine to send already queued MDNs and treat them as already sent.
adbenitez
approved these changes
Aug 13, 2026
MDNs to self are used for seen status synhronization between devices.
link2xt
force-pushed
the
link2xt/always-send-mdn-to-self
branch
from
August 13, 2026 11:16
48a4e5b to
6d9cc9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MDNs to self are used for seen status synhronization between devices.
Closes #8577