refactor: remove MessengerMessage - #8566
Merged
Merged
Conversation
link2xt
commented
Aug 11, 2026
| context, | ||
| "Ignoring ephemeral timer change to {ephemeral_timer:?} for chat {chat_id} because sender {from_id} is not a member.", | ||
| ); | ||
| } else if is_dc_message == MessengerMessage::Yes |
Collaborator
Author
There was a problem hiding this comment.
The only logic change is here, the rest of the code is maintaining msgrmsg column and testing it.
link2xt
force-pushed
the
link2xt/yunrlkmkmwwu
branch
from
August 11, 2026 19:17
8d9de50 to
a17ab03
Compare
link2xt
marked this pull request as ready for review
August 11, 2026 19:29
Collaborator
Author
|
Somewhat related to #8493, was trying to understand why do we still need |
link2xt
force-pushed
the
link2xt/yunrlkmkmwwu
branch
from
August 11, 2026 20:20
a17ab03 to
83e88fc
Compare
hpk42
approved these changes
Aug 11, 2026
Contributor
|
sidenote: the commit is prefixed "refactor" while it does slightly change user-observable behaviour. But i don't overly care and certainly don't like holding up or delaying merges of PRs with relatively minor comments or nits (i approved already). |
This value is not used for any logic except the disappearing messages timer rollback prevention. It is unlikely that non-chat clients participate in chats with disappearing messages, and the case was not tested anyway.
link2xt
force-pushed
the
link2xt/yunrlkmkmwwu
branch
from
August 12, 2026 05:56
83e88fc to
8819296
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This value is not used for any logic
except the disappearing messages timer rollback prevention. It is unlikely that non-chat clients
participate in chats with disappearing messages,
and the case was not tested anyway.