fix: improve connectivity HTML if quota info error#8130
Open
Conversation
WofWca
changed the title
Currently if the provider doesn't support quota info the HTML displays something like ``` example.com: Connected Not supported by your provider. ``` It's not clear that "not supported" only refers to quota info.
WofWca
force-pushed
the
wofwca/quota-error-html
branch
from
80ea722 to
ca807dc
Compare
iequidoo
approved these changes
Apr 16, 2026
| Err(e) => { | ||
| ret += &escaper::encode_minimal(&e.to_string()); | ||
| // TODO translate "Quota". | ||
| ret += &format!("Quota: {}", &*escaper::encode_minimal(&e.to_string())); |
Collaborator
There was a problem hiding this comment.
Maybe add a stock str with a function that takes the encoded error as an argument? And UIs will translate it later
Collaborator
|
Maybe better just not display anything at all if quota is not supported? User cannot do anything about it, they will have to see "Quota: Not supported by your provider." below each transport that does not support it. |
Collaborator
Author
|
Good idea. Though I guess we would still want to display the text if it's a different kind of error? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if the provider doesn't support quota info
the HTML displays something like
It's not clear that "not supported" only refers to quota info.