Include fixes for low TX power on SX126x and issues with compiling on some platforms#33
Open
LithosphereRocketry wants to merge 3 commits intochandrawi:mainfrom
Open
Include fixes for low TX power on SX126x and issues with compiling on some platforms#33LithosphereRocketry wants to merge 3 commits intochandrawi:mainfrom
LithosphereRocketry wants to merge 3 commits intochandrawi:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is built on top of mads03dk's PR for better LLCC68 support - it could be reasonably cherry-picked out if preferred.
Include two main fixes:
Remove unwanted return as per issue #16
Makes base class functions pure virtual to address issue #29