fix: pass per-repo pipeline dirs to melange compile#36
Draft
justinvreeland wants to merge 1 commit into
Draft
Conversation
The shellcheck-run-steps hook hardcoded a single --pipeline-dir flag derived from the file's parent directory. This fails for packages in enterprise-packages/ and extra-packages/ that reference pipelines from other tiers (e.g. pipelines/py/pip-vendor-bump.yaml). Add a PIPELINE_DIRS mapping matching stereo's dirToPipelineDirs so each package tier gets the correct set of --pipeline-dir flags passed to melange compile. Fixes OS-2428
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shellcheck-run-stepshook hardcoded a single--pipeline-dirflag derived from the file's parent directory. This fails for packages inenterprise-packages/andextra-packages/that reference pipelines from other tiers (e.g.pipelines/py/pip-vendor-bump.yaml).PIPELINE_DIRSmapping matching stereo'sdirToPipelineDirsso each package tier gets the correct set of--pipeline-dirflags passed tomelange compile.Fixes the failure Chris Herborth hit when committing
enterprise-packages/graalvm-25.yamlin a git worktree.Resolves OS-2428
🤖 Generated with Claude Code