Refactor to support BoxLang alongside ACF,Lucee#450
Open
lanechase34 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Results:
2 failing tests in BoxLang still - not sure if they are resolvable. The FileGetMimeType() seems to always look at the content rather than the extension in BoxLang. I am not familiar with a password protected xlsx file - I haven't really looked into that test too deep.
-- can read the csv from a text file with an .xls extension (12 ms)
-- Can write an XLSX file encrypted with a password (89 ms) - The supplied POIFSFileSystem does not contain a BIFF8 'Workbook' entry. Is it really an excel file? Had: []
2 failing tests in Lucee6, Lucee7 - these were present before the changes I made were done.
-- Sets the specified cell to the specified date value even if the Lucee timezone doesn't match the system (13 ms) - Expected [42106] but received [42105.8]
-- allows the format of date and time values to be customised (11 ms) - Expected [2019-04-12] but received [2019-04-11]
ACF2025 all tests pass.