Search input BEM validation#604
Closed
flacoman91 wants to merge 1 commit into
Closed
Conversation
|
Collaborator
Author
|
not needed. see cfpb/design-system#2693 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #390
This is similar to #602
This is similar to #603
Question for @anselmbradford:
I noticed some inconsistencies with how
a-text-input__fullclass is being used or not used in the search componentshould it be
a-text-input--full?https://cfpb.github.io/design-system/components/text-inputs
The DS documentation lists __full, but i've seen
a-text-input--fullas well asa-text-input__full.I don't see any rules for __full