Skip to content

ENT-14927: Fixed cf-serverd crash when policy reload races with a new connection (3.24.x) - #6492

Open
github-actions[bot] wants to merge 1 commit into
3.24.xfrom
backport-6464-3.24.x
Open

github-actions[bot] wants to merge 1 commit into
3.24.xfrom
backport-6464-3.24.x

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Backport of #6464 by @aleksandrychev to 3.24.x.

Opened automatically by .github/workflows/backport.yml.

Pull requests opened with GITHUB_TOKEN do not trigger other workflows, so CI has not started on its own.

cf-serverd only checked ACTIVE_THREADS before reloading policy, but a
connection is added to SERVER_ACCESS.connectionlist before its handler
thread increments ACTIVE_THREADS and removed only after it decrements it.
A reload in that window tripped the assertion in ClearAuthAndACLs().
Policy reload and shutdown cleanup now also wait for connections that
are still in connectionlist.

Ticket: ENT-14927
Changelog: Title
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Ihor Aleksandrychiev <ihor.aleksandrychiev@northern.tech>
(cherry picked from commit 4dec79a)
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant