Repository navigation
CFE-3478: Added isvalidip: function for validating IP addresses - #6486
Merged
Merged
Conversation
Ticket: CFE-3478 Signed-off-by: Victor Moene <victor.moene@northern.tech>
larsewi
approved these changes
Nov 10, 2026
Contributor
|
@cf-bottom Jenkins please :) |
craigcomstock
approved these changes
Nov 10, 2026
craigcomstock
left a comment
craigcomstock
left a comment
Contributor
There was a problem hiding this comment.
I noticed something cargo-cult here that kind of bothered me... the handling of finalargs and writing code determining the quantity of args or pulling the args out.
But this is fine as-is. Maybe a ticket for refactoring/improvement as a follow up.
| { | ||
| assert(fp != NULL); | ||
|
|
||
| if (finalargs == NULL || |
Contributor
There was a problem hiding this comment.
shouldn't we write/use a function that makes this expression more obvious to it's meaning? I know the message after is pretty clear but reading ->next and ->next->next is kind of non-obvious at a glance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge together: cfengine/documentation#3827