Backport macOS CI fixes to 3.27.x - #6364
Merged
Merged
Conversation
Changelog: title Signed-off-by: Victor Moene <victor.moene@northern.tech> As of LMDB 1.0.0, MDB_MAXKEYSIZE defaults to 0 (computed from the page size) instead of the fixed compile-time 511 used by LMDB <1.0.0, and mdb_env_get_maxkeysize() only returns the correct value once the environment has actually been opened (env->me_maxkey is populated by mdb_env_open()). So this can only be checked after a successful open, not beforehand like it could with older LMDB versions. The assertion breaks on macos because the environement there uses a newer lmdb package. (cherry picked from commit 0e31cc1)
Author
|
Note for reviewers: the first commit here (cherry-pick of 0e31cc1, "Fixed lmdb maxkeysize assertion for macos") is also carried by #6363 (as 6ed5868). Whichever PR merges second can drop its copy — both are identical Generated by Claude Code |
larsewi
approved these changes
Sep 24, 2026
Contributor
|
@claude please backport to 3.24.x also |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ole Herman · Slack thread
The macos-26 unit-test job fails on 3.27.x-based PRs because Homebrew now ships LMDB >= 1.0.0, and 3.27.x still has the old
assert(mdb_env_get_maxkeysize(env) == 511)inlibpromises/dbm_lmdb.c, which aborts under LMDB 1.x. Master fixed this in 0e31cc1. This backport unblocks green CI on nova PR https://github.com/cfengine/nova/pull/2710 (backport of the memory-safety fixes), whose macos-26 unit-test job builds core at the PR's base branch.Cherry-picked commits (with
-x):🤖 Generated with Claude Code
https://claude.ai/code/session_01GRomi2LQjL5yBJjado36eg