ENT-14195 3. Event handling for file deletion - #6355
Merged
larsewi merged 2 commits intoSep 25, 2026
Merged
Conversation
victormlg
changed the title
|
Thank you for submitting a pull request! Maybe @larsewi can review this? |
victormlg
force-pushed
the
event-handling-3-file-deletion
branch
4 times, most recently
from
September 23, 2026 14:40
0321282 to
c033d62
Compare
craigcomstock
left a comment
craigcomstock
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Maybe some semantic word changes to be clear that all of this is about files being deleted instead of files existing.
victormlg
force-pushed
the
event-handling-3-file-deletion
branch
from
September 24, 2026 07:17
fc172c0 to
57c2aea
Compare
larsewi
reviewed
Sep 24, 2026
larsewi
reviewed
Sep 24, 2026
Signed-off-by: Victor Moene <victor.moene@northern.tech>
Signed-off-by: Victor Moene <victor.moene@northern.tech>
victormlg
force-pushed
the
event-handling-3-file-deletion
branch
from
September 24, 2026 10:33
57c2aea to
bfaad9e
Compare
larsewi
approved these changes
Sep 24, 2026
Contributor
|
@cf-bottom Jenkins please :) |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14701/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14701/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File deletion
In this PR we create a new event type for file deletion with all the necessary code to be working in the logic of watcher.c