Skip to content

Adjust IsReadable() for Termux environment without pthread_cancel() - #6249

Open
craigcomstock wants to merge 6 commits into
cfengine:masterfrom
craigcomstock:CFE-4401-2/master
Open

Adjust IsReadable() for Termux environment without pthread_cancel()#6249
craigcomstock wants to merge 6 commits into
cfengine:masterfrom
craigcomstock:CFE-4401-2/master

Conversation

@craigcomstock

@craigcomstock craigcomstock commented Jul 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No description provided.

@craigcomstock

craigcomstock commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

Wanted to post this PR to get github's opinion on the changes. The commits have been in the works for a long time and need to be adjusted as they include gradual changes and improvements that should be collected into fewer commits. Will do soon.

@olehermanse
olehermanse requested a review from larsewi July 29, 2026 13:32
@craigcomstock
craigcomstock marked this pull request as ready for review July 29, 2026 13:41
@craigcomstock

craigcomstock commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

Wanted to post this PR to get github's opinion on the changes. The commits have been in the works for a long time and need to be adjusted as they include gradual changes and improvements that should be collected into fewer commits. Will do soon.

they have been reworked. ready to go.

larsewi
larsewi reviewed Jul 29, 2026
View reviewed changes

@larsewi larsewi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to bump libntech in 42daf08? If so, it should probably go to a separate commit. Furthermore, the last commit message title is a bit confusing. Otherwise LGTM

@craigcomstock
craigcomstock force-pushed the CFE-4401-2/master branch 2 times, most recently from 1ac7e4c to 3d3d2e1 Compare July 29, 2026 20:39
@olehermanse

olehermanse commented Jul 30, 2026

Copy link
Copy Markdown
Member

@cf-bottom jenkins, please

@cf-bottom

cf-bottom commented Jul 30, 2026

Copy link
Copy Markdown

Sure, I triggered a build:

Build Status

Jenkins: https://ci.cfengine.com/job/pr-pipeline/14370/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14370/

@craigcomstock
Adjusted IsReadable() to not use pthread_cancel() on Termux platform
1acdb54 
instead use MaskTerminationSignalsInThread() from libntech

Ticket: CFE-4401
Changelog: title
@craigcomstock
Fixed check for copy_file_range on Android
fcf357e 
AC_CHECK_FUNCS apparently doesn't take into account the __ANDROID_API__ level properly and so incorrectly determines that copy_file_range is available for termux at API 24 but copy_file_range is <= 34.

Ticket: none
Changelog: none
@craigcomstock
Adjusted dbm_test_api.c to build on alpine linux with musl libc
2d83c36 
The re-entrant versions of srand() and friends aren't technically required and not using them enables compilation on platforms without glibc.

Ticket: none
Changelog: none
@craigcomstock
Temporary bump for libntech craigcomstock/cfe-4401 branch that leaves…
251966a 
… out MaskTerminationSignalsInThread() on mingw platform

That function has unsupported functions on mingw platform with pthreads-w32.

Remove this commit when NorthernTechHQ/libntech#287 is merged
@olehermanse

olehermanse commented Jul 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

From CI:

../libntech/libutils/platform.h:309: error: "alloca" redefined [-Werror]

Edit: Likely unrelated to this PR, seen in libntech upgrade PR as well.

olehermanse
olehermanse requested changes Jul 30, 2026
View reviewed changes

@olehermanse olehermanse left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this needs a rebase now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olehermanse olehermanse olehermanse requested changes
@larsewi larsewi larsewi approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@craigcomstock @olehermanse @cf-bottom @larsewi