CFE-4661: Fixed an issue where wrong names in --clients would cause cf-remote to hang#186
Open
sarakthon wants to merge 2 commits into
Open
CFE-4661: Fixed an issue where wrong names in --clients would cause cf-remote to hang#186sarakthon wants to merge 2 commits into
sarakthon wants to merge 2 commits into
Conversation
olehermanse
changed the title
olehermanse
requested changes
Jun 5, 2026
olehermanse
left a comment
olehermanse
left a comment
Member
There was a problem hiding this comment.
Let's do a f2f review on this one
sarakthon
force-pushed
the
check-name
branch
3 times, most recently
from
c56bfed to
e625027
Compare
olehermanse
requested changes
Jun 11, 2026
olehermanse
left a comment
olehermanse
left a comment
Member
There was a problem hiding this comment.
Please add a comment in this PR showing what you have tested (commands and output), before and after your changes.
olehermanse
requested changes
Jun 12, 2026
Member
|
Test failure is unrelated and should be fixed by #189 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Command and output before changes:
Testing
cf-remote installwith wrong/undefined name in--clients:The command gives no output, and the program hangs for an indefinite time period.
Command and output after changes: