Skip to content
This repository was archived by the owner on Sep 17, 2025. It is now read-only.

Added support for Flask 2. Setup.py-dependency bumped to < 3.0.0. Closes #1022#1072

Open
mortendaehli wants to merge 3 commits into
census-instrumentation:masterfrom
mortendaehli:master
Open

Added support for Flask 2. Setup.py-dependency bumped to < 3.0.0. Closes #1022#1072
mortendaehli wants to merge 3 commits into
census-instrumentation:masterfrom
mortendaehli:master

Conversation

@mortendaehli

@mortendaehli mortendaehli commented Sep 1, 2021

Copy link
Copy Markdown

FlaskMiddleware is compatible with Flask 2. The dependency is thus bumped in setup.py to < 3.0.0.

Closes #1022

@mortendaehli

Copy link
Copy Markdown
Author

By the way, this is my first open source PR. Please let me know if I should do anything different, or if you have any advice. I have read the contributing guidelines and the code of conduct and tried to follow doing my best :)

@mortendaehli

Copy link
Copy Markdown
Author

@aabmass, could you please review this?

@jamescw

jamescw commented Sep 22, 2021

Copy link
Copy Markdown

I was just about to make a PR for this and I'm glad I found one already open!

This is desperately needed, it causes havoc on dependency resolution between popular packages that rely on flask:

The conflict is caused by:
    The user requested flask==2.0.0
    flask-smorest 0.34.0 depends on flask<3 and >=2.0
    flask-sqlalchemy 2.5.0 depends on Flask>=0.10
    flask-marshmallow 0.13.0 depends on Flask
    opencensus-ext-flask 0.7.5 depends on flask!=1.1.3, <2.0.0 and >=0.12.3

Maybe one for @lzchen

@aberres

aberres commented Oct 25, 2021

Copy link
Copy Markdown
Contributor

@lzchen Could this be merged? 🙏🏼

@mortendaehli

Copy link
Copy Markdown
Author

I have updated the PR to solve a merge conflict.

@aabmass aabmass left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and apologies for the slow response. LGTM

@aabmass

aabmass commented Nov 16, 2021

Copy link
Copy Markdown
Member

Any idea about the python 3.5 error? Is it related to flask 2 only supporting python3.7+?

@jo47011

jo47011 commented Dec 9, 2021

Copy link
Copy Markdown

Could this be merged? 🙏🏼

@mortendaehli

Copy link
Copy Markdown
Author

Flask 2 does not support Python 3.5. Any chance we could drop Python 3.5? It reached end of life more than 1 year ago.

@lzchen lzchen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review. Regarding the Python 3.5 error, we have not decided to stop supporting Py3.5 yet. Perhaps you can modify the tox file to simply ignore running on 3.5 for now?

@jo47011

jo47011 commented Feb 3, 2022

Copy link
Copy Markdown

Any news on this issue? We would really appreciate the merge as our security scanner forces us to disable this package until then :( Thanks a lot.

@gabrieligbastos

Copy link
Copy Markdown

+1 any preview to release new package allowing to use with flask 2?

@gabloe

gabloe commented Mar 14, 2022

Copy link
Copy Markdown

Ping. Any update on this?

@louisbergmann

Copy link
Copy Markdown

Ping. We would be very interested in an update here as we are not able to use the new awesome Flask version with support for multi threading.

@jonasmiederer

Copy link
Copy Markdown

Same, desperately waiting for this PR to be merged and released

@QuintenDV

Copy link
Copy Markdown

This is also blocking us at the moment.

@danielsbarros

Copy link
Copy Markdown

Any news here? what's happening on the py35 build?

@lzchen

lzchen commented Apr 15, 2022

Copy link
Copy Markdown
Contributor

@mortendaehli
Could you rebase and modify the tox file to not test on Py3.5?

This was referenced Apr 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Opencensus not working with Flask 2