Skip to content

pipewire: read a modifier choice at the right offset #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcelerier merged 1 commit into from
Sep 12, 2026
Merged

pipewire: read a modifier choice at the right offset #255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 11 additions & 13 deletions include/libremidi/backends/linux/pipewire/format.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,21 +179,19 @@ inline bool extract_modifier_choice(

if (spa_pod_is_choice(val))
{
const auto* choice = reinterpret_cast<const spa_pod_choice*>(val);
const spa_pod* child = SPA_POD_CHOICE_CHILD(reinterpret_cast<const spa_pod_choice*>(val));
const std::uint32_t child_size = SPA_POD_BODY_SIZE(child);
const std::uint32_t n_values
= (SPA_POD_BODY_SIZE(val) - sizeof(spa_pod_choice_body)) / child_size;
const std::uint8_t* p = static_cast<const std::uint8_t*>(SPA_POD_CONTENTS(spa_pod_choice, val))
+ sizeof(spa_pod_choice_body);
for (std::uint32_t i = 0; i < n_values; ++i)
// SPA_POD_CHOICE_VALUES already skips the pod header and the choice body.
const std::uint32_t value_size = SPA_POD_CHOICE_VALUE_SIZE(val);
const std::uint32_t n_values = SPA_POD_CHOICE_N_VALUES(val);
const auto* p = static_cast<const std::uint8_t*>(SPA_POD_CHOICE_VALUES(val));
if (value_size == sizeof(std::int64_t))
{
std::int64_t v;
std::memcpy(&v, p, sizeof(v));
out_choices.push_back(static_cast<std::uint64_t>(v));
p += child_size;
for (std::uint32_t i = 0; i < n_values; ++i, p += value_size)
{
std::int64_t v;
std::memcpy(&v, p, sizeof(v));
out_choices.push_back(static_cast<std::uint64_t>(v));
}
}
(void)choice;
return true;
}

Expand Down
Loading