Skip to content

Conversation

@aaronmgdr
Copy link
Contributor

@aaronmgdr aaronmgdr commented May 23, 2025

Description

set default node version for test runs to 22

Other changes

make it so the ci tests can easily be run with other node versions

Tested

naturally

How to QA

n/a

Related issues


PR-Codex overview

This PR focuses on refactoring the codebase to improve the handling of client objects, specifically transitioning to a unified Clients type. It also updates various configurations and dependencies, enhances test scripts, and modifies command parameters for better clarity and functionality.

Detailed summary

  • Updated node-version from 20 to 22 in workflow files.
  • Refactored functions to use a unified Clients type instead of separate PublicClient and WalletClient.
  • Modified command parameters for vote, getEpochManagerContract, and others to accept Clients.
  • Adjusted test scripts to improve reliability and added retries.
  • Deprecated useAKV flag documentation updated for clarity.
  • Updated inline snapshots in tests to reflect new expected values.
  • Enhanced error handling in the vote function for better feedback.
  • Removed redundant imports and streamlined client retrieval in various commands.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented May 23, 2025

⚠️ No Changeset found

Latest commit: 6d1700f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 1 package
Name Type
@celo/celocli Major

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented May 23, 2025

Codecov Report

Attention: Patch coverage is 18.84058% with 56 lines in your changes missing coverage. Please review.

Project coverage is 68.86%. Comparing base (5a2fa51) to head (6d1700f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #653      +/-   ##
==========================================
- Coverage   76.32%   68.86%   -7.46%     
==========================================
  Files         278      152     -126     
  Lines       11243     7028    -4215     
  Branches     1733     1143     -590     
==========================================
- Hits         8581     4840    -3741     
+ Misses       2527     2097     -430     
+ Partials      135       91      -44     
Components Coverage Δ
celocli ∅ <ø> (∅)
sdk 69.36% <ø> (ø)
wallets 73.12% <ø> (ø)
viem-sdks 94.15% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2025

size-limit report 📦

Path Size
require('@celo/actions') (cjs) 95.37 KB (0%)
import * from '@celo/actions' (esm) 23.7 KB (0%)
import { resolveAddress } from '@celo/actions' (esm) 23.61 KB (0%)
import { getGasPriceOnCelo } from '@celo/actions' (esm) 73 B (0%)
import * from '@celo/actions/chains' (esm) 329 B (0%)
import { getAccountsContract } from '@celo/actions/contracts/accounts' (esm) 45.61 KB (+0.02% 🔺)
import * from '@celo/actions/staking' (esm) 52.31 KB (+0.12% 🔺)

@aaronmgdr aaronmgdr changed the base branch from aaronmgdr/contract-require-clients to master May 26, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setup Multi Node Version tests

2 participants