Skip to content

Conversation

@agarny
Copy link
Contributor

@agarny agarny commented Jan 14, 2026

Fixes #1353.

Copilot AI review requested due to automatic review settings January 14, 2026 04:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request fixes issue #1353 by standardizing variable naming in generated code from CamelCase to snake_case. The changes convert references to algebraicVariables, algebraic, externalVariables to their snake_case equivalents: algebraic_variables, external_variables.

Changes:

  • Updated Python function signatures to use algebraic_variables parameter instead of algebraic
  • Renamed all variable references from algebraicVariables to algebraic_variables in Python files
  • Renamed all variable references from externalVariables to external_variables in Python files
  • Updated C/C++ header function signatures to use algebraicVariables instead of algebraic
  • Bumped version numbers from "0.6.0"/"0.7.0" to "0.8.0" across test resource files

Reviewed changes

Copilot reviewed 232 out of 243 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/resources/generator/variable_initialised_using_another_variable/model.py Updated variable naming from CamelCase to snake_case and version bump
tests/resources/generator/variable_initialised_using_another_variable/model.h Updated function signature parameter name
tests/resources/generator/variable_initialised_using_another_variable/model.c Updated function signature and version
tests/resources/generator/unknown_variable_as_external_variable/model.* Standardized naming conventions for algebraic and external variables
tests/resources/generator/sine_model_imports/model.* Updated variable references and function signatures
tests/resources/generator/robertson_model_1966/model.. Applied consistent naming throughout ODE and DAE variants
tests/resources/generator/ode_/model. Standardized variable naming across multiple ODE test cases
tests/resources/generator/noble_model_1962/model.* Updated all variable references to snake_case
tests/resources/generator/hodgkin_huxley_squid_axon_model_1952/model.. Comprehensive updates across all model variants (ODE, DAE, external, tracking, etc.)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Code generation: still need to convert some "algebraic" stuff to "algebraic variable"

1 participant