Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a new S3 integration module for storing XWiki attachment content in Amazon S3-compatible object storage, providing an alternative to filesystem-based storage.
Changes:
- Added S3 configuration management with credential handling and client initialization
- Implemented S3-backed attachment content storage with CRUD operations
- Created new Maven module with AWS SDK S3 dependency
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 12 comments.
| File | Description |
|---|---|
| celements-s3/src/main/java/com/celements/store/s3/S3Config.java | Spring configuration class that creates and configures S3Client bean with credential management and bucket validation |
| celements-s3/src/main/java/com/celements/store/s3/S3AttachmentContentStore.java | Implementation of AttachmentContentStore interface for S3-based attachment storage with versioned key structure |
| celements-s3/pom.xml | Maven configuration for new S3 integration module with AWS SDK dependency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
celements-s3/src/main/java/com/celements/store/s3/S3AttachmentContentStore.java
Outdated
Show resolved
Hide resolved
celements-s3/src/main/java/com/celements/store/s3/att/S3AttachmentContentStore.java
Show resolved
Hide resolved
celements-s3/src/main/java/com/celements/store/s3/S3AttachmentContentStore.java
Show resolved
Hide resolved
celements-s3/src/main/java/com/celements/store/s3/att/S3AttachmentContentStore.java
Outdated
Show resolved
Hide resolved
celements-s3/src/main/java/com/celements/store/s3/att/S3AttachmentContentStore.java
Show resolved
Hide resolved
celements-s3/src/main/java/com/celements/store/s3/S3Config.java
Outdated
Show resolved
Hide resolved
celements-s3/src/main/java/com/celements/store/s3/att/S3AttachmentContentStore.java
Show resolved
Hide resolved
fpichler
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.