Avoid renumbering the ASTs when no mutations are applied to the AST. - #1207
Open
copybara-service[bot] wants to merge 1 commit into
Open
Avoid renumbering the ASTs when no mutations are applied to the AST.#1207copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
We want to use referential identity to check is the AST was the same pre/post-optimization. To do this, we need to make sure that we apply `renumberIdsConsecutively` only if the AST was actually mutated. Until now, we updated the CEL-Java optimizers - see cl/976189920. PiperOrigin-RevId: 977455819
copybara-service
Bot
force-pushed
the
test_977455819
branch
from
September 8, 2026 09:10
d6a6f57 to
1ec9a72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid renumbering the ASTs when no mutations are applied to the AST.
We want to use referential identity to check is the AST was the same pre/post-optimization. To do this, we need to make sure that we apply
renumberIdsConsecutivelyonly if the AST was actually mutated.Until now, we updated the CEL-Java optimizers - see cl/976189920.