Skip to content

Implement strings.format in CEL string extensions. #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement strings.format in CEL string extensions. #1165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions conformance/src/test/java/dev/cel/conformance/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,9 +115,6 @@ _TESTS_TO_SKIP_LEGACY = [

# Skip until fixed.
"fields/qualified_identifier_resolution/map_value_repeat_key_heterogeneous",
# TODO: Add strings.format.quote.
"string_ext/format",
"string_ext/format_errors",

# Future features for CEL 1.0
# TODO: Strong typing support for enums, specified but not implemented.
Expand All @@ -143,10 +140,6 @@ _TESTS_TO_SKIP_LEGACY = [
]

_TESTS_TO_SKIP_PLANNER = [
# TODO: Add strings.format.
"string_ext/format",
"string_ext/format_errors",

# TODO: This is actually a user experience degradation.
# Not worth fixing until we see a concrete need.
"basic/functions/unbound_is_runtime_error",
Expand Down
5 changes: 5 additions & 0 deletions extensions/src/main/java/dev/cel/extensions/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,12 @@ java_library(
"//checker:checker_builder",
"//common:compiler_common",
"//common/internal",
"//common/internal:comparison_functions",
"//common/internal:date_time_helpers",
"//common/types",
"//common/types:type_providers",
"//common/values",
"//common/values:cel_byte_string",
"//compiler:compiler_builder",
"//extensions:extension_library",
"//runtime",
Expand Down
Loading