guard int32/uint32 map key narrowing in qualifyInternal#1337
Open
alhudz wants to merge 2 commits into
Open
Conversation
TristonianJones
previously approved these changes
Jun 12, 2026
TristonianJones
approved these changes
Jun 15, 2026
Collaborator
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro: indexing a native
map[int32]anywith a key outside theint32range, e.g.m[4294967296]wherem == {0: "x"}, returns"x"instead of a no-such-key error. Same formap[uint32]any.Cause:
intQualifier.qualifyInternalanduintQualifier.qualifyInternalcast theint64/uint64index toint32/uint32before the lookup, so4294967296wraps to0and collides with the entry stored at key0.Fix: only perform the narrowed lookup when the index round-trips through the key type (
int64(int32(i)) == i), otherwise fall through to the existing missing-key path.