Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
box_duplicates="error", reassigning an existing converted key incorrectly raises a duplicate-attribute error. With"warn", the same update produces a warning. For example,b = Box({"a b": 1}, box_duplicates="error"); b["a b"] = 2fails because the existing safe alias is treated as a different conflicting key.Only flag a conversion duplicate when the alias points to a different original key. Tests cover dictionary and attribute updates under both policies, then verify that a genuinely different colliding key still raises or warns. The changelog and author list are updated per the contribution guide.
Validation: all four new cases fail before the fix; the complete suite passes after it on Python 3.13 (163 tests) with the Cython build and required format backends. The configured Black 24.10 whole-tree check and Mypy (8 source files) pass;
git diff --checkpasses. The PR targets the requireddevelopbranch.