Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
default_box=True,Box().pop("missing", fallback)ignores the explicit fallback and calls the configured default factory. Ifdefault_box_create_on_get=False, it can instead raiseBoxKeyErrorwhile deleting the generated but unstored value.Use the existing default-suppression lookup for
popcalls with an explicit fallback, and propagate it through dotted Box and BoxList paths. Return the original fallback object without calling the factory or creating missing values. Add regressions for both creation modes, scalar/collection fallbacks, nested mapping/list paths, and existing camel-case keys. Include the changelog and contributor entry requested by the guide.Validation on Linux/Python 3.14: 11 of the 12 new cases fail on unchanged
develop; all 171 tests pass in pure Python and again after compiling the runtime with Cython, with the declared optional test dependencies installed. Black with the project configuration, Pyflakes, and mypy (8 source files) pass.