Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BoxListchecks the input's truth value before iterating. A NumPy array with multiple elements therefore raisesValueError, while an iterable with a false truth value silently loses its contents.Check whether the input is
Noneinstead. Add regressions for both kinds of iterable, including conversion of their dictionaries into Boxes. Empty and default inputs keep their existing behavior.Validation: both new cases fail before the change; all 161 tests pass afterward on Python 3.14. Wheel and sdist builds pass. The modified files have the same eight Ruff diagnostics as the unchanged base, with no new diagnostics. Also checked with NumPy 2.5.3 arrays containing zero, multiple values, and no values.