Repository navigation
Conversation
Author
|
Tidying up my open PRs, so I'm closing this one while the repo seems inactive. Feel free to ping me and I'll reopen or rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Cython-built Box raises
TypeError: expected str, got re.Patternwhen a stringbox_dots_excludeis propagated to nested boxes or reconstructed during copying. Box compiles the string internally, but its two constructor annotations and stubs only allowstr | None.Correct those signatures to
str | re.Pattern[str] | None, matching the values already accepted by pure Python and passed through internal configuration. Keep the existing normalization and regex flags. Add regressions for both string and compiled-pattern inputs, nested mappings/lists, and copying.Validation:
Those probes also record the existing option reset in
BoxList.__deepcopy__; copied-child states match the pure-Python baseline rather than being reported as complete option preservation.AI-assisted implementation and validation with Codex.